Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Always resize filesystems and LUKS to the maximum possible #19514

Merged
merged 1 commit into from
Oct 25, 2023
Merged

storage: Always resize filesystems and LUKS to the maximum possible #19514

merged 1 commit into from
Oct 25, 2023

Conversation

mvollmer
Copy link
Member

This is always the right thing to do, since Cockpit will first resize the block device (which is a logical volume or partition) and then resize the content to match. This will cover the case where the block device resizing ended up with something different from what we asked for.

@mvollmer
storage: Always resize filesystems and LUKS to the maximum possible
3c544f9 
This is always the right thing to do, since Cockpit will first resize
the block device (which is a logical volume or partition) and then
resize the content to match.  This will cover the case where the block
device resizing ended up with something different from what we asked
for.
@mvollmer mvollmer temporarily deployed to gh-cockpituous October 23, 2023 11:56 — with GitHub Actions Inactive
@mvollmer mvollmer requested a review from jelly October 23, 2023 11:56
@mvollmer
Copy link
Member Author

mvollmer commented Oct 23, 2023 •
edited
Loading

Hopefully fixes #19493

@mvollmer mvollmer mentioned this pull request Oct 23, 2023
Merged
jelly
jelly approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have figured out how to reproduce this xfs issue when I made the bug report.. But this in general seems to be a good approach! (And tests agree)

@jelly
Copy link
Member

jelly commented Oct 24, 2023

Anaconda test is an pixel test flake so ignoring that.

@mvollmer mvollmer merged commit e1aa8e1 into cockpit-project:main Oct 25, 2023
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelly jelly jelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvollmer @jelly